Skip to content

Conversation

@serhalp
Copy link

@serhalp serhalp commented Nov 5, 2025

Changes

See https://github.com/netlify/primitives/releases/tag/functions-v5.0.0. The breaking changes do not apply here, as we're only using the type exports, which are unchanged.

Without accounting for deduping, this removes 310 transitive dependencies and 82 MB from the @astrojs/netlify dependency tree.

Testing

N/A — no user-facing changes

Docs

N/A — no user-facing changes

@changeset-bot
Copy link

changeset-bot bot commented Nov 5, 2025

🦋 Changeset detected

Latest commit: 1e71e4a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Nov 5, 2025
@ematipico ematipico added this to the v5.16.0 milestone Nov 5, 2025
'@astrojs/netlify': patch
---

Upgrades `@netlify/functions` to v5. This removes 82 MB and 310 dependencies from the dependency tree. See [the relevant release notes](https://github.com/netlify/primitives/releases/tag/functions-v5.0.0).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Upgrades `@netlify/functions` to v5. This removes 82 MB and 310 dependencies from the dependency tree. See [the relevant release notes](https://github.com/netlify/primitives/releases/tag/functions-v5.0.0).
Upgrades the `@netlify/functions` dependency to v5. This removes 82 MB and 310 dependencies from the dependency tree.
There are no breaking changes to Astro's Netlify adapter in this release, even though this is a major dependency upgrade. See [the Netlify release notes](https://github.com/netlify/primitives/releases/tag/functions-v5.0.0) for more details about `@netlify/functions` v5.

Just wanted to be clear about no breaking changes for us, since this is a major dependency upgrade. (e.g. Ema's first reaction was to question this, so it should go in the notes so that people aren't wondering the same thing themselves!) So maybe something like above? (Please correct if the wording could be more accurate)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 As a developer, I would be surprised if I saw release notes for my dependency that mentioned a lack of breaking changes in an upgrade of one of its dependencies.

A dependency's dependencies are an implementation detail (until they aren't 😆). So I would personally suggest just documenting what the impact of the change is for @astrojs/netlify's users—in this case, it's a smaller dependency tree and faster install size.

Of course this is just my opinion! Let me know 🙂.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: integration Related to any renderer integration (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants